src: remove unused shouldRetryAsESM internal binding#58265
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 12, 2025
Merged
Conversation
nodejs-github-bot
added
c++
anonrig
approved these changes
May 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58265 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.01%
==========================================
Files 629 629
Lines 186639 186617 -22
Branches 36654 36655 +1
==========================================
- Hits 168313 168275 -38
+ Misses 11134 11114 -20
- Partials 7192 7228 +36
🚀 New features to boost your workflow:
|
dario-piotrowicz
added
the
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
added
author ready
lpinca
approved these changes
May 11, 2025
RaisinTen
approved these changes
May 11, 2025
jasnell
approved these changes
May 12, 2025
UlisesGascon
approved these changes
May 12, 2025
marco-ippolito
approved these changes
May 12, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 200abfc |
dario-piotrowicz
deleted the
dario/remove-shouldRetryAsESM-unused-internal-binding
branch
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58265 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58265 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is removing the
shouldRetryAsESMinternal binding, which I believe is no longer used.I believe that the binding stopped being used in #52047.