doc: optimize the doc about Unix abstract socket#52043
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 19, 2024
Merged
doc: optimize the doc about Unix abstract socket#52043nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
4 tasks
ShogunPanda
reviewed
Mar 11, 2024
ShogunPanda
approved these changes
Mar 11, 2024
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
Little nit but rest LGTM.
theanarkh
force-pushed
the
optimize_net_doc
branch
from
182badb to
3093ef8
Compare
lpinca
approved these changes
Mar 11, 2024
theanarkh
added
the
fast-track
Contributor
|
Fast-track has been requested by @theanarkh. Please 👍 to approve. |
legendecas
requested changes
Mar 13, 2024
theanarkh
removed
the
fast-track
theanarkh
force-pushed
the
optimize_net_doc
branch
from
3093ef8 to
8e8bbe4
Compare
legendecas
approved these changes
Mar 18, 2024
theanarkh
added
the
author ready
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7071554 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52043 Refs: nodejs#50904 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimize the doc about Unix abstract socket
Refs: #50904
make -j4 test(UNIX), orvcbuild test(Windows) passes