Skip to content

build: add workaround for No module named 'distutils.spawn'#30221

Closed
gengjiawen wants to merge 3 commits intonodejs:masterfrom
gengjiawen:doc/wsl
Closed

build: add workaround for No module named 'distutils.spawn'#30221
gengjiawen wants to merge 3 commits intonodejs:masterfrom
gengjiawen:doc/wsl

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Nov 2, 2019 •
edited
Loading

Fix: #30189

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 2, 2019
cclauss
cclauss approved these changes Nov 2, 2019
View reviewed changes
@gengjiawen
build: add workaround for WSL
f4b1bf7 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
cclauss
cclauss reviewed Nov 2, 2019
View reviewed changes
mscdex
mscdex reviewed Nov 2, 2019
View reviewed changes
@cclauss cclauss changed the title build: add workaround for WSL build: add workaround for No module named 'distutils.spawn' Nov 3, 2019
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Nov 3, 2019
richardlau
richardlau reviewed Nov 3, 2019
View reviewed changes
@gengjiawen gengjiawen requested a review from richardlau November 4, 2019 01:31
@cclauss
Copy link
Contributor

cclauss commented Nov 4, 2019

CI-Lite https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4029/

@cclauss
Copy link
Contributor

cclauss commented Nov 4, 2019

Landed in ed2c3ca

@cclauss cclauss closed this Nov 4, 2019
cclauss pushed a commit that referenced this pull request Nov 4, 2019
@gengjiawen @cclauss
build: add workaround for WSL
ed2c3ca 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #30221
Fixes: #30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Nov 5, 2019
@gengjiawen @targos
build: add workaround for WSL
49e7f04 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #30221
Fixes: #30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@gengjiawen @targos
build: add workaround for WSL
a8adcd0 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #30221
Fixes: #30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@gengjiawen @targos
build: add workaround for WSL
fc360ed 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #30221
Fixes: #30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@gengjiawen @targos
build: add workaround for WSL
a0974d6 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #30221
Fixes: #30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@gengjiawen @targos
build: add workaround for WSL
bcd2238 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #30221
Fixes: #30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@richardlau richardlau richardlau approved these changes

@guybedford guybedford Awaiting requested review from guybedford

+1 more reviewer

@mscdex mscdex mscdex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build: No module named 'distutils.spawn'

5 participants

@gengjiawen @cclauss @mscdex @richardlau @nodejs-github-bot