Conversation
8ed79ba to
56a7db2
Compare
|
remade the branch and cherry-picked the HEAD commit onto it so it's properly on v5.x now, will watch Travis to see what it says, regardless I don't think this is (a) needed or (b) requires us to document it, it's just not something we can change on v5.x because it's been baked in already. |
56a7db2 to
f5e6151
Compare
|
I rebased on v5.x at same time you did so who knows what we got. Let’s see what Travis says. If it fails then I believe our release notes should reflect that. |
|
Flake8 no longer supports Python 2.6 but even when flake8 is fully disabled, the Py26 run fails. |
b0886b7 to
5951add
Compare
|
it failed because it's running Node 0.10 on that image, I switched to 10 ( |
|
Try upgrading to trusty |
|
green with trusty 👍 will merge this into v5.x |
PR-URL: #1913 Reviewed-By: Rod Vagg <rod@vagg.org>
2979a1c to
d1cf121
Compare
|
No, I won't add this, because it disables flake8 for everything, we'll need to differentiate before it can land. I've cleaned it up into a single commit on top of the current v5.x and force pushed it up. |
Checklist
npm install && npm testpassesDescription of change
As discussed in #1912, we need to test software that we claim to support.