v5.x: Add Python 3.5 and 3.6 tests on Linux#1909
Closed
cclauss wants to merge 2 commits intonodejs:v5.xfrom
Closed
v5.x: Add Python 3.5 and 3.6 tests on Linux#1909cclauss wants to merge 2 commits intonodejs:v5.xfrom
cclauss wants to merge 2 commits intonodejs:v5.xfrom
Conversation
sam-github
suggested changes
Oct 3, 2019
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
This is a backport of #1903 to 5.x, I think, but it shouldn't contain the docs, they don't seem applicable.
Member
|
@cclauss the point of keeping a v5.x branch is to keep it like the current published version, accepting only Python 2. Or am I missing something? Here, it makes sense to add testing to Travis. its behind the However, the README changes look wrong - Python 3 is not supported here, and it's not supposed to be. Unless I'm wrong, the README changes should be removed from this PR. |
sam-github
approved these changes
Oct 3, 2019
Contributor
Author
|
Reverted all changes to README.md. |
Member
4 tasks
rvagg
pushed a commit
that referenced
this pull request
Oct 4, 2019
PR-URL: #1909 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
Member
|
fantastic, landed in 3834156 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
As requested at #1905 (comment) this PR features #1903 -like changes but this PR is based on the v5.x branch and is intended to land in the v5.0.5 release.
The Travis changes mean that we are now testing on Python 2.7, 3.5, 3.6, and 3.7 os on Unix and macOS we will support all four. On Windows, we are not recommending the use of Micorsoft's Python so this release will only support legacy Python on Windows.