allow double-digit versions in XcodeVersion#1854
allow double-digit versions in XcodeVersion#1854roryqueue wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Related to #1849 ? |
|
yes, relates-- sorry at work and not able to dig further atm, but that change seems to fix |
|
(or rather, obviously doesn't work given it's failing, but the regex change matches both 9.X and 10.X, where as the other one fails on 10.X, so could be a hint to a real fix) |
|
Sorry, I'm not a python person but this looks invalid to me, |
|
Can we just replace this line with version = ".".join(version.split(".")[:3]) and move on? Not a fan of regex for trivial use cases. |
|
I believe that #1890 fixed this. Please rebase and reverify. |
|
Conflicts to resolve. |
|
I think this is dealt with already and the solution posed here isn't correct as far as I can tell |
Fixes #1849
Checklist
npm install && npm testpassesDescription of change