build: set Python semverRange: '>=2.7.0 <3.8.0'#1813
build: set Python semverRange: '>=2.7.0 <3.8.0'#1813cclauss wants to merge 2 commits intonodejs:masterfrom
Conversation
lib/configure.js
Outdated
| argsExecutable: ['-c', 'import sys; print(sys.executable);'], | ||
| argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'], | ||
| semverRange: '>=2.6.0 <3.0.0', | ||
| semverRange: '>=2.7.0 <3.8.0', |
There was a problem hiding this comment.
Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.
There was a problem hiding this comment.
Now it is semverRange: '>=2.7.0'
|
These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality. |
|
Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black? |
| python: 3.7 | ||
| before_install: nvm install 12 | ||
| allow_failures: | ||
| - os: osx |
lib/configure.js
Outdated
| argsExecutable: [ '-c', 'import sys; print(sys.executable);' ], | ||
| argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ], | ||
| semverRange: '>=2.6.0 <3.0.0', | ||
| argsExecutable: [ '-c', 'import sys; print(sys.executable)' ], |
There was a problem hiding this comment.
is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.
|
other than small comments, LGTM |
joaocgreis
left a comment
joaocgreis
left a comment
There was a problem hiding this comment.
This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.
|
Closing in favor of #1815 |
5 participants
Checklist
npm install && npm testpassesDescription of change
Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.