Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 21, 2025

The goal is to remove the need to clone the repo in https://github.com/nodejs/node/blob/main/.github/workflows/notify-on-push.yml, and instead rely on push.commits like so:

- name: Validate commits
  run: echo "$COMMITS" | npx -q core-validate-commit -
  env:
    COMMITS: ${{ toJSON(github.event.commits) }}

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this :)

Comment on lines +310 to +312
ls.on('close', (code) => {
tt.equal(code, 1, 'CLI exits with non-zero code on error')
tt.match(errorData, /Input must be an array/, 'error message is shown')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems likely to create bad DX. If it's not an array, just wrap it in an array.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a use-case for passing a non-array, we can consider it. Until then, it's probably more helpful to throw an error.

aduh95 and others added 2 commits January 20, 2026 22:06
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@aduh95 aduh95 merged commit 3200730 into main Jan 20, 2026
5 checks passed
@aduh95 aduh95 deleted the json-stdin branch January 20, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants