-
-
Notifications
You must be signed in to change notification settings - Fork 53
feat: add support for stdin JSON input #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this :)
| ls.on('close', (code) => { | ||
| tt.equal(code, 1, 'CLI exits with non-zero code on error') | ||
| tt.match(errorData, /Input must be an array/, 'error message is shown') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems likely to create bad DX. If it's not an array, just wrap it in an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a use-case for passing a non-array, we can consider it. Until then, it's probably more helpful to throw an error.
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
The goal is to remove the need to clone the repo in https://github.com/nodejs/node/blob/main/.github/workflows/notify-on-push.yml, and instead rely on
push.commitslike so: