Conversation
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM though I wish we had a bit more summary about the new features in the text?
(Speaking of which, we should also add the character length limit validation to the workflow).
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
|
I am typing on my phone so I don't know if these fit in 300 chars, but I think this is the list that can be put into the post (maybe we can cut some if it's too long, or we can send a reply to the first post)
According to my testing in joyeecheung/bluesky-playground#10 line breaks via \n works. |
|
Yeah the following text is already 283 char, it would need to be a response – which I think needs to be another PR, I don't think we support making threads Notable changes:
- `assert.partialDeepStrictEqual()`
- `--trace-env`
- `net.BlockList.isBlockList()`
- `net.SocketAddress.parse()`
- BlockList support in `net.Server` and `net.connect`
- unflag `node:sqlite`
- `StatementSync.prototype.iterate()`
- new Collaborator @jordan.har.band |
|
How about It's 289 chars, and we can add |
|
(Also another note, we can support file reference in the JSON, so that the rich text content can be put into a .txt, and the workflow can read it and JSON.stringify it) |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
I tested it in joyeecheung/bluesky-playground#11 which triggered https://bsky.app/profile/pixel-voyager.bsky.social/post/3lcxuadloj62p - looks good! |
|
It seems the branch deletion is automatic, after some googling I found So I disabled it in the repo setting. |
* post: v23.4.0 announcement * Update records/new/v23.4.0-announcement.json Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> * Update records/new/v23.4.0-announcement.json Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> --------- Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
* post: v23.4.0 announcement (#17) * post: v23.4.0 announcement * Update records/new/v23.4.0-announcement.json Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> * Update records/new/v23.4.0-announcement.json Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> --------- Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> * Update v23.4.0-announcement.json --------- Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
About It seems a repost of https://bsky.app/profile/jordan.har.band/post/3lcixvbt24k2e is more apt? |
Refs: nodejs/node#56119