This repository was archived by the owner on Jan 31, 2024. It is now read-only.
Add support for content loaded in an iframe on the modal.#69
Open
yorch wants to merge 5 commits intonikku:mainfrom
Open
Add support for content loaded in an iframe on the modal.#69yorch wants to merge 5 commits intonikku:mainfrom
yorch wants to merge 5 commits intonikku:mainfrom
Conversation
|
Great stuff getting the iFrame to work - I am having issues closing the Modal once it has loaded. |
Owner
|
Hi Steven, you have to make sure you open the whole application on a local webserver. Otherwise AJAX will not work. Cheers, Nico |
|
I see, sorry I forgot to open it in the www folder. Next issue is trying to change the height of the Modal - I am using Yorch's iFrame plugin which is proving difficult without documentation. Right now it is stuck on width: 560px; height: 155px; I have tried to change the height in the javascrip call. |
|
hey there, I am using the iframe extension - but I would like to to open the iframe on pageload... I have tried to add an id tag and use the following code - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Thanks for your plugin, great work!
I've made a plugin that relies on yours to support URLs to be loaded on an iframe inside a modal. Feel free to pull it if you find it useful.
Thanks,
Jorge.