This repository was archived by the owner on Jan 31, 2024. It is now read-only.
Add response,status,xhr,form,dialog params to dialog2.ajax-complete. Fix extra spaces in lines.#52
Open
felipe-prenholato wants to merge 1 commit intonikku:mainfrom
Open
Add response,status,xhr,form,dialog params to dialog2.ajax-complete. Fix extra spaces in lines.#52felipe-prenholato wants to merge 1 commit intonikku:mainfrom
felipe-prenholato wants to merge 1 commit intonikku:mainfrom
Conversation
Owner
|
Yes. Could you please update your pull request? To remove these additional changes? |
Author
|
I'm out of time, but I'll fix this week, probably in weekend. |
Author
|
Lines 45 to 47 in commit. |
Author
|
Ahn, @nikku, maybe is a nice opportunity to think what events should send response, or loaded content, etc, and also change this ones. Also, a note about sending dialog to event, I did it because I can't close dialog in other way. If we need to access dialog from any event how we do it without send dialog as argument to binded function? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, with that patch I made dialog2.ajax-complete event usefull. With that params I can have much more control over ajax process.