add app-dark.svg#839
add app-dark.svg#839wonderfulShrineMaidenOfParadise wants to merge 3 commits intonextcloud:masterfrom
Conversation
wonderfulShrineMaidenOfParadise
force-pushed
the
icon
branch
from
b75d7f5 to
90b6b35
Compare
wonderfulShrineMaidenOfParadise
changed the title
wonderfulShrineMaidenOfParadise
force-pushed
the
icon
branch
from
621d0c0 to
17ded70
Compare
Dark version of app.svg from 18615eb Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
Set the icon for the notification. Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
Also rename the section from 'additional' to 'passman'. Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
wonderfulShrineMaidenOfParadise
force-pushed
the
icon
branch
from
17ded70 to
0513ee0
Compare
|
thanks for the pr, it looks quite interesting. I'll try to check it out soon^TM |
There was a problem hiding this comment.
From a technical perspective I'm fine with it, already tested it and it works well. Thanks @wonderfulShrineMaidenOfParadise .
I am not sure about the new Passman settings section. Personally I like it, but the documentation says:
It is also possible that an app registers its own section. This should be done only if there is no fitting corresponding section and the app’s settings form takes a lot of screen estate. Otherwise, register to “additional”.
and well, our settings does not take "a lot of screen estate" and fits well in “additional”.
On the other hand, it would simplify finding the Passman settings at all.
@animalillo what would you say?
2 participants
img: add app-dark.svg
Dark version of app.svg from 18615eb
OCA\Passman\Notifier: setIcon()
Set the icon for the notification.
OCA\Passman\Settings: add AdminSection
Also rename the section from
additionaltopassman.