Fixed white on white issue when header background is RBG color#484
Open
alexcustos wants to merge 3 commits intonextcloud:masterfrom
Open
Fixed white on white issue when header background is RBG color#484alexcustos wants to merge 3 commits intonextcloud:masterfrom
alexcustos wants to merge 3 commits intonextcloud:masterfrom
Conversation
Contributor
|
Tests are failing due to #497 |
Collaborator
|
@alexcustos Can you explain how to reproduce this error exactly and for what to watch out so that i can test this? Also, could you sign your commits? Without that we cannot merge them :/ |
Author
|
@newhinton I'm not using Passman anymore. A lot of changed in Nextcloud theming since that time, so I'm not sure if this issue still relevant. But it was easy to reproduce by setting the primary color to #FFFFFF in the default theming app. Entire Nextcloud handled it very well, but not Passman. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem with white themes. For some reason, jQuery returns RGB color which cannot be processed well by use-theme directive. Here the fix for this issue.