feat: add namespaceSelector on serviceMonitor#524
Merged
provokateurin merged 1 commit intonextcloud:mainfrom Feb 5, 2024
Merged
feat: add namespaceSelector on serviceMonitor#524provokateurin merged 1 commit intonextcloud:mainfrom
provokateurin merged 1 commit intonextcloud:mainfrom
Conversation
wrenix
changed the title
provokateurin
requested changes
Feb 4, 2024
Co-authored-by: Richard Boldiš <richard@boldis.dev> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: WrenIX <dev.github@wrenix.eu>
wrenix
force-pushed
the
fix/metrics-namespaceselector
branch
from
0b65845 to
704829e
Compare
provokateurin
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
updated from #349
for this Commit exists already some review in # #481
Checklist
Chart.yamlaccording to semver.