[NTC-4957] Fixed parsing Palo banners that start on the same line

[joewesch]

Closes: #780

This PR changes the logic a bit when dealing with Palo Alto banners that start on the same line as login-banner. The existing test only tests if they start with an empty line:

          login-banner "
************************************************************************

But a banner isn't required to have a blank line on the first line.

          login-banner "####################################################
WARNING TO UNAUTHORIZED USERS:

[itdependsnetworks]

Can you add a ConfigLine output of this as well? Want to make sure it renders correctly. Otherwise, looks good :)

[jeffkala]

Is " the only allowed delimeter?

[joewesch]

It seems that way, yes. Because it's technically saved in XML it is just using double quotes here for this format.

      <login-banner admin="ntc" dirtyId="23" time="2026/01/27 16:15:46">####################################################
WARNING TO UNAUTHORIZED USERS:
This system is for use by authorized users only.
Any individual using this system, by such use,
acknowledges and consents to the right of the
company to monitor, access, use, and disclose any
information generated, received, or stored on the
systems, and waives any right of privacy or
expectation of privacy on the part of that
individual in connection with his or her use of
this system. Unauthorized and/or improper use of
this system, as delineated by corporate policies,
is not tolerated and the company may take formal
action against such individuals.
####################################################
</login-banner>

You can't even escape the double quotes:

ntc@pa-ntc# set deviceconfig system login-banner "test"

[edit]
ntc@pa-ntc# set deviceconfig system login-banner "test"test"

Invalid syntax.
[edit]
ntc@pa-ntc# set deviceconfig system login-banner "test\"test"

Invalid syntax.
[edit]
ntc@pa-ntc#

[itdependsnetworks]

Shouldn't all of this be in a single config_line? I think that is how we do banners.

[joewesch]

No. The line that starts the banner (e.g., banner motd or banner login) is one line and the whole banner is another line that has a parent of the banner start. It just so happens that part of this banner is on the first line.

Arista banner for example:

netutils/tests/unit/mock/config/parser/base/arista_eos/eos_full_received.py

Lines 158 to 162 in fab65da

	ConfigLine(config_line="banner login", parents=()),
	ConfigLine(
	config_line="********************************************************************\n* This system is the property of Allied Widget Co. *\n* UNAUTHORIZED ACCESS TO THIS DEVICE IS PROHIBITED *\n* *\n* You must have explicit, authorized permission to access or *\n* configure this device. Unauthorized attempts and actions to *\n* access or use this system may result in civil and/or criminal *\n* penalties. *\n* *\n* All activities performed on this deviceare logged and monitored. *\n********************************************************************\nEOF",
	parents=("banner login",),
	),

[joewesch]

The config has it on the same line, so having the parent be just set deviceconfig system login-banner would not be exact.