INTERNAL: Add logging for NOT_SUPPORTED response while authenticating#1036
Merged
jhpark816 merged 1 commit intonaver:developfrom Jan 19, 2026
Merged
INTERNAL: Add logging for NOT_SUPPORTED response while authenticating#1036jhpark816 merged 1 commit intonaver:developfrom
jhpark816 merged 1 commit intonaver:developfrom
Conversation
jhpark816
reviewed
Jan 14, 2026
| } else if ("NOT_SUPPORTED".equals(msg)) { | ||
| authDone = true; | ||
| node.authComplete(true); | ||
| getLogger().warn("Authentication not supported by server, skipping auth flow"); |
Collaborator
There was a problem hiding this comment.
@namsic
코드로 보니, node 정보도 추가하는 것이 좋을 것 같습니다.
확인해 주세요.
Collaborator
There was a problem hiding this comment.
위 Authenticated to " + node.getSocketAddress() 로그와 유사하게 아래와 같이 할 수 있어 보입니다.
"Authentication not supported by server, skipping auth flow: " + node.getSocketAddress()
jhpark816
approved these changes
Jan 19, 2026
namsic
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did