Fied wing updates#304
Conversation
Apa, Cruise Mode and fix for Vector trust.
Moved Motor code
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_338.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_339.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_340.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_341.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_342.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_343.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_344.html |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_345.html |
|
please don't commit hex files with your patches.
|
src/fw_nav.c
Outdated
There was a problem hiding this comment.
#defines do not belong inside functions.
move it outside.
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_347.html |
|
Building this PR Failed :/ |
|
Successfully built this PR! |
|
You're still trying to commit baseflight.hex. |
src/fw_nav.c
Outdated
There was a problem hiding this comment.
spacing
scaler = (GEO_SKAL... etc
|
Successfully built this PR! |
|
Successfully built this PR! |
|
Successfully built this PR! |
|
OK, as long as this stuff builds I can let this in for now. Once the new one is merged I'll close this one. |
|
Actually, maybe better do this; To squash them all. |
|
Also, please rename trust -> thrust in the code, there's no need to pollute with incorrect variable names. |
|
Hey, let's get these last 2 things fixed so I can merge this? |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_354.html |
|
Building this PR Failed :/ |
|
Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_355.html |
|
Building this PR Failed :/ |
|
Successfully built this PR! |
|
In one comment trust was not replaced (in mw.h), and I saw some indent errors (in mw.h and mixer.c). I have squashed the commits, removed the changes to the hex file and rebased it on the current master. If needed I can submit a new pull request (or list the git commands to repeat the steps) |
|
Thanks for cleanup. Up to you, @EmilsPa is probably sick of these emails at this point. On Wed, Jan 6, 2016 at 7:48 PM, Johannes notifications@github.com wrote:
|
|
Fix the merge please. Started to look at cleaning up the TPA. |
|
@schugabe, you heard the man :) On Wed, Jan 6, 2016 at 9:47 PM, EmilsPa notifications@github.com wrote:
|
|
Is there some way to do the Jenkins check before committing? |
|
Biggest thing is the style, you can install astyle and run this: Should fix many issues. |
New GPS mode for Fixed Wing.
Cruise Mode.
Modified TPA to use Angle for attenuation.
Fixes for Vector trust on Twin Engine planes.
Changed RollComp to integer float don't work well with Gui.