Fixed autocomplete bug for documentation search.js on mobile devices#197
Closed
smistad wants to merge 1 commit intomosra:masterfrom
Closed
Fixed autocomplete bug for documentation search.js on mobile devices#197smistad wants to merge 1 commit intomosra:masterfrom
smistad wants to merge 1 commit intomosra:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 98.28% 98.18% -0.11%
==========================================
Files 27 27
Lines 6646 6655 +9
Branches 44 46 +2
==========================================
+ Hits 6532 6534 +2
- Misses 114 121 +7
Continue to review full report at Codecov.
|
friendlyanon
pushed a commit
to friendlyanon/m.css
that referenced
this pull request
Jul 15, 2021
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #196
Detect if browser is on mobile device, and if so skip the appending of autocomplete text.
Detecting mobile browser taken from here: https://stackoverflow.com/questions/11381673/detecting-a-mobile-browser
Should probably just hide the key guide in the search dialog as well on mobile since they are not relevant...?