Skip to content

Conversation

@wpbonelli
Copy link
Member

Close #2610

@wpbonelli wpbonelli added this to the 3.10 milestone Jan 26, 2026
@wpbonelli wpbonelli marked this pull request as ready for review January 26, 2026 11:05
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.3%. Comparing base (556c088) to head (6f41142).
⚠️ Report is 116 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2690      +/-   ##
===========================================
+ Coverage     55.5%    72.3%   +16.8%     
===========================================
  Files          644      667      +23     
  Lines       124135   130394    +6259     
===========================================
+ Hits         68947    94377   +25430     
+ Misses       55188    36017   -19171     
Files with missing lines Coverage Δ
flopy/utils/postprocessing.py 80.1% <100.0%> (+2.5%) ⬆️

... and 562 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

heads,
m,
heads=None,
m=None,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the model should not default to None, it is required

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads should also not default to None, just interpret an explicitly passed None as fully saturated

@wpbonelli wpbonelli merged commit b48d7e3 into modflowpy:develop Jan 29, 2026
20 checks passed
@wpbonelli wpbonelli deleted the feat-2610 branch January 29, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: interpret no head in get_transmissivities as fully saturated

2 participants