Add meta to Client methods
#1923
Open
+167
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Jan 21, 2026
| from mcp.server.fastmcp import FastMCP | ||
| from mcp.shared.session import ProgressFnT | ||
|
|
||
| logger = logging.getLogger(__name__) |
Member
Author
There was a problem hiding this comment.
Changes here are not breaking change.
Member
Author
There was a problem hiding this comment.
Adding the meta parameter in the methods here is also not a breaking change, because they have a default value. Which means is just a feature.
| "TaskExecutionMode", | ||
| "TaskStatus", | ||
| # Base classes | ||
| "MCPModel", |
Member
Author
There was a problem hiding this comment.
MCPModel should be internal. It's not supposed to be exposed.
A lot of types here aren't supposed to be exposed.
| model_config = ConfigDict(extra="allow", alias_generator=to_camel, populate_by_name=True) | ||
|
|
||
|
|
||
| Meta: TypeAlias = dict[str, Any] |
Member
Author
There was a problem hiding this comment.
The Meta type was being used as dict[str, Any] or as class Meta(BaseModel) depending on the class, which doesn't make sense. I've set dict[str, Any] for all of them, which matches the spec and most of the types here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.