-
Notifications
You must be signed in to change notification settings - Fork 340
mcp: update JSON marshaling to not HTML-escape messages #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+176
−9
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright 2025 The Go MCP SDK Authors. All rights reserved. | ||
| // Use of this source code is governed by the license | ||
| // that can be found in the LICENSE file. | ||
|
|
||
| // Package mcpgodebug provides a mechanism to configure compatibility parameters | ||
| // via the MCPGODEBUG environment variable. | ||
| // | ||
| // The value of MCPGODEBUG is a comma-separated list of key=value pairs. | ||
| // For example: | ||
| // | ||
| // MCPGODEBUG=someoption=1,otheroption=value | ||
| package mcpgodebug | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "strings" | ||
| ) | ||
|
|
||
| const compatibilityEnvKey = "MCPGODEBUG" | ||
|
|
||
| var compatibilityParams map[string]string | ||
|
|
||
| func init() { | ||
| var err error | ||
| compatibilityParams, err = parseCompatibility(os.Getenv(compatibilityEnvKey)) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| } | ||
|
|
||
| // Value returns the value of the compatibility parameter with the given key. | ||
| // It returns an empty string if the key is not set. | ||
| func Value(key string) string { | ||
| return compatibilityParams[key] | ||
| } | ||
|
|
||
| func parseCompatibility(envValue string) (map[string]string, error) { | ||
| if envValue == "" { | ||
| return nil, nil | ||
| } | ||
|
|
||
| params := make(map[string]string) | ||
| for part := range strings.SplitSeq(envValue, ",") { | ||
| k, v, ok := strings.Cut(part, "=") | ||
| if !ok { | ||
| return nil, fmt.Errorf("MCPGODEBUG: invalid format: %q", part) | ||
| } | ||
| params[strings.TrimSpace(k)] = strings.TrimSpace(v) | ||
| } | ||
| return params, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // Copyright 2025 The Go MCP SDK Authors. All rights reserved. | ||
| // Use of this source code is governed by the license | ||
| // that can be found in the LICENSE file. | ||
|
|
||
| package mcpgodebug | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/google/go-cmp/cmp" | ||
| ) | ||
|
|
||
| func TestParseCompatibility_Success(t *testing.T) { | ||
maciej-kisiel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| tests := []struct { | ||
| name string | ||
| envVal string | ||
| want map[string]string | ||
| }{ | ||
| { | ||
| name: "Basic", | ||
| envVal: "foo=bar,baz=qux", | ||
| want: map[string]string{ | ||
| "foo": "bar", | ||
| "baz": "qux", | ||
| }, | ||
| }, | ||
| { | ||
| name: "Empty", | ||
| envVal: "", | ||
| want: nil, | ||
| }, | ||
| { | ||
| name: "WithWhitespace", | ||
| envVal: " foo = bar \t, baz = qux ", | ||
| want: map[string]string{ | ||
| "foo": "bar", | ||
| "baz": "qux", | ||
| }, | ||
| }, | ||
| { | ||
| name: "WithEqualsSignInValue", | ||
| envVal: "foo=bar=baz", | ||
| want: map[string]string{ | ||
| "foo": "bar=baz", | ||
| }, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got, err := parseCompatibility(tt.envVal) | ||
| if err != nil { | ||
| t.Fatalf("parseCompatibility() failed: %v", err) | ||
| } | ||
| if diff := cmp.Diff(tt.want, got); diff != "" { | ||
| t.Errorf("parseCompatibility() mismatch (-want +got):\n%s", diff) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestParseCompatibility_Failure(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| envVal string | ||
| }{ | ||
| { | ||
| name: "NoEqualsSign", | ||
| envVal: "invalidformat", | ||
| }, | ||
| { | ||
| name: "MixedValidAndInvalid", | ||
| envVal: "foo=bar,baz", | ||
| }, | ||
| { | ||
| name: "EmptyPart", | ||
| envVal: "foo=bar,,baz=qux", | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| _, err := parseCompatibility(tt.envVal) | ||
| if err == nil { | ||
| t.Error("parseCompatibility() expected error, got nil") | ||
| } | ||
| }) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.