fix: error in hardhat deployed func, use new Hardhat deploy func#2
Open
0xemrekaya wants to merge 1 commit intomode-network:mainfrom
Open
fix: error in hardhat deployed func, use new Hardhat deploy func#20xemrekaya wants to merge 1 commit intomode-network:mainfrom
0xemrekaya wants to merge 1 commit intomode-network:mainfrom
Conversation
Author
|
@fede2442 Could you check this PR?, thanks sir. |
0xemrekaya
changed the title
0xemrekaya
changed the title
Contributor
|
Checked and figured out that hardhat included hardhat ignition into their building and deployment flow, we'll need to update the entire article. @0xemrekaya thanks for pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request includes the following changes to use the new deploy features of Hardhat v2.0.0^:
deployContract()function is used instead of the oldgetContractFactory()anddeploy()functions.getAddress()function is used instead of oldaddress.WHY?
In Hardhat v2.0.0, a number of changes were made to the deploy process, including the
deployContractandwaitForDeploymentfunctions. So the old code was not working, so I updated it with the new version.the old code has a error:
If you need more information about Hardhat v2.0.0^ check this guides: https://hardhat.org/hardhat-runner/docs/guides/deploying