Skip to content

Conversation

@zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Jan 28, 2026

Some small fixes making all tests pass on Windows:

  • Initialize ArrayDesc::data_size otherwise empty arrays which usually do not call array::set_data would get garbage data.
  • Only use tensor ops in grouped mm when tf32 is enabled.
  • Avoid accessing outputs[1] in SDPA when output_logsumexp is false.
  • Do not try to get vjp for mask in test_sdpa_grad.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@zcbenz zcbenz merged commit 8ef5395 into ml-explore:main Jan 30, 2026
16 checks passed
@zcbenz zcbenz deleted the win-last-tests branch January 30, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants