Open
Conversation
Author
|
Looks like there are some other changes that need to be made, like andSelf -> addBack |
added 2 commits
November 4, 2022 11:01
mitya33
requested changes
Jan 5, 2023
Owner
mitya33
left a comment
There was a problem hiding this comment.
Thanks for this - I appreciate your contribution. However, it's quite duplicative. It's possible to accomplish your edits to support jQuery >= 3 with less code, as follows:
- For the
addBack()vs.andSelf()thing, instead of repeating the entire blocks of code, you can just do:
$('.foo')[jquery_ver >= 3 ? 'addBack' : 'andSelf']()
- For the
.error()vs..fail()part, just use.fail()- that's supported sine v.1.5 - Also, please don't feel the need to add extra
{and}. This is down to coding style, and mine is not to have unnecessary brackets, though I know many would disagree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2