This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Precompute decode hooks for performance reason#324
Open
Succo wants to merge 2 commits intomitchellh:mainfrom
Open
Precompute decode hooks for performance reason#324Succo wants to merge 2 commits intomitchellh:mainfrom
Succo wants to merge 2 commits intomitchellh:mainfrom
Conversation
Author
|
Some of the comments got updated due to gofmt change in behaviour. I can revert this part if it's a problem (or open a different PR just for it) |
|
@mitchellh We've noticed the same performance issues as @Succo . Are there any plans to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this library with ComposeDecodeHook we noticed some performance degration. After further investigation, it seems that a lot of time is spent inside typedDecodeHook on reflect func.
I think it would be possible to precompute the typedDecodeHook for all hooks given to ComposeDecodeHook. I applied the same patch to OrComposeDecodeHookFunc event though we don't use it.