Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

decodeMapFromSlice should ignore ZeroFields when not first element#276

Open
timestee wants to merge 3 commits intomitchellh:mainfrom
sandwich-go:master
Open

decodeMapFromSlice should ignore ZeroFields when not first element#276
timestee wants to merge 3 commits intomitchellh:mainfrom
sandwich-go:master

Conversation

@timestee
Copy link

Thanks for this project, I've had a config file merge and load implementation using this project, and got a wired problem: sandwich-go/xconf#6

for i := 0; i < dataVal.Len(); i++ {
err := d.decode(
name+"["+strconv.Itoa(i)+"]",
dataVal.Index(i).Interface(), val)
if err != nil {
return err
}
}

Should decodeMapFromSlice ignore ZeroFields when i != 0 ? Otherwise, the merged map will be clean again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants