Fix testresample.c output span; add exit code#7
Open
matt-har-vey wants to merge 1 commit intominorninth:masterfrom
Open
Fix testresample.c output span; add exit code#7matt-har-vey wants to merge 1 commit intominorninth:masterfrom
matt-har-vey wants to merge 1 commit intominorninth:masterfrom
Conversation
Prior to this chance, the "Resample with different factors" test only passed for 60 of the 63 factors, with the 3 failing ones being the largest. 1. Since only 63 distinct factors were being considered, 100 random samples was overkill. 2. To support noticing failure in continuous build systems, it's nice if the test exit()s with nonzero when there are failures. 3. The root cause was a formula error when determining which indices in the resampled output ought be compared. Details are explained in a comment.
Contributor
|
@minorninth Just a ping to take a look at this; this PR would fix the testing machinery added in #8. If you could merge this and tag a 0.1.5 release on the GitHub repository it’d be great for us and other downstreams :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this chance, the "Resample with different factors" test only passed for 60 of the 63 factors, with the 3 failing ones being the largest.