Skip to content

Conversation

@azchohfi
Copy link
Collaborator

@azchohfi azchohfi commented Jan 6, 2026

Fixes #142

@azchohfi azchohfi enabled auto-merge (squash) January 6, 2026 02:57
Copy link
Member

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. before merging:

  • Need to have msstore team review and approve
  • Usage docs updated to include store command and link to msstore docs
  • Readme updated to include store command in the list of commands
  • Add tests
  • Should we have a silent install option (install MSStoreCLI if not installed) for things like CI? Or a command to ensure it is installed prior to calling it winapp store ensure-available? The second option seems better to me.

@azchohfi azchohfi requested a review from nmetulev January 6, 2026 19:26
@azchohfi
Copy link
Collaborator Author

azchohfi commented Jan 8, 2026

  • Should we have a silent install option (install MSStoreCLI if not installed) for things like CI? Or a command to ensure it is installed prior to calling it winapp store ensure-available? The second option seems better to me.

We have 3 options:

  1. Assume that the command we have is interactive, since it requires accepting the store's EULA (through winget). We are using the winget's "Microsoft Store" source, and that source requires accepting the EULA at first usage.
    Not sure how that works in CI though. Also, this is a solved problem (msstore cli installation in CI), that we might not want to solve again (https://github.com/microsoft/microsoft-store-apppublisher). Its a single line in their yaml file.:
    - uses: microsoft/microsoft-store-apppublisher@v1.2

But we are passing that burden to them, which is not ideal.

  1. Add a --silent, or something around these lines, that will just force installation by passing --acept-soure-agreements to winget. This might work.

  2. We change the installation method to be similar to what https://github.com/microsoft/microsoft-store-apppublisher does, which means moving away from using winget and using the GitHub release to download the zip of a specific version. We then extract that folder to our "tools" folder within the global .winapp folder, which is a known folder for us, so we just call it. Would also work fine, and this is probably the more complete solution, but is way more work on us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy msstore CLI commands

3 participants