Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Addresses review feedback on #7258 to remove underscore from public static readonly field name.

Changes:

  • Renamed TestClassShouldHaveTestMethodRule_BaseClassHasAssemblyAttributes to TestClassShouldHaveTestMethodRuleBaseClassHasAssemblyAttributes
  • Updated all references in analyzer and test code

Aligns with .editorconfig rule requiring PascalCase for static readonly fields without underscores.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 30, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • u3hvsblobprodcus371.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.26067.2.txt (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update field name format in MSTEST0016 description Remove underscore from field name to comply with naming conventions Jan 30, 2026
Copilot AI requested a review from Evangelink January 30, 2026 16:03
@Evangelink Evangelink marked this pull request as ready for review February 2, 2026 10:40
@Evangelink Evangelink merged commit 074135e into dev/amauryleve/analyzer-message Feb 2, 2026
10 checks passed
@Evangelink Evangelink deleted the copilot/sub-pr-7258 branch February 2, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants