Add settings to launch debugger on test failure #7318
+58
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Jan 30, 2026
| internal static void ThrowAssertFailed(string assertionName, string? message) | ||
| => throw new AssertFailedException( | ||
| { | ||
| if (AssertionFailureSettings.LaunchDebuggerOnFailure) |
Member
Author
There was a problem hiding this comment.
This is acting only on assertion failures, we could also consider the same call in case of an exception being thrown or a timeout occuring in the test.
nohwnd
approved these changes
Feb 2, 2026
Member
|
Will the debugger launch block in non-interactive session / interactive ci session? Maybe you want to detect CI and not do it. |
Youssef1313
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2033.
I have thought about having this as a platform feature but there is really few code to add. Besides, it would need to be introduced through a new mechanism as the message bus we are using could result in the debugger launch being triggered pretty far from the time of error.