-
Notifications
You must be signed in to change notification settings - Fork 291
Fix cursor positioning when Console.BufferWidth exceeds Console.WindowWidth #7305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-console-buffer-width-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l positioning Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix console output for large BufferWidth values
Fix cursor positioning when Console.BufferWidth exceeds Console.WindowWidth
Jan 28, 2026
Evangelink
reviewed
Jan 28, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Jan 28, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Jan 28, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
nohwnd
reviewed
Jan 29, 2026
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
...ests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Console.BufferWidthis set larger thanConsole.WindowWidth, test progress timings display incorrectly or not at all. MTP uses ANSI cursor positioning to place timings on the right edge, but was calculating positions usingBufferWidthinstead ofWindowWidth.Changes
IConsole interface
WindowWidthandWindowHeightpropertiesTerminal implementations
SimpleTerminalandAnsiTerminalnow useWindowWidth/WindowHeightinstead ofBufferWidth/BufferHeightfor theirWidth/HeightpropertiesTests
SimpleTerminal_UsesWindowWidthNotBufferWidthandAnsiTerminal_UsesWindowWidthNotBufferWidthto verify behavior when buffer ≠ window dimensionsExample scenario
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
5rqvsblobprodcus385.vsblob.vsassets.io/home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.26077.1.txt(dns block)/usr/bin/dotnet dotnet build src/Platform/Microsoft.Testing.Platform/Microsoft.Testing.Platform.csproj -c Release kload.emscripten.net9(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.