CHORE: Remove unused methods from helpers.py & Fix PR Description
#399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 69.4%
mssql_python.pybind.ddbc_bindings.h: 69.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 84.1%
mssql_python.cursor.py: 84.7%🔗 Quick Links
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes unused helper functions from the mssql_python.helpers module as part of a code cleanup effort. The removed functions previously handled connection string manipulation but are no longer used in the codebase.
Changes:
- Removed
add_driver_to_connection_strfunction that previously injected ODBC driver into connection strings - Removed
add_driver_name_to_app_parameterfunction that previously ensured APP parameter was set - Removed unused import of
add_driver_to_connection_strfrom connection.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mssql_python/helpers.py | Removed two unused helper functions related to connection string manipulation |
| mssql_python/connection.py | Removed unused import of add_driver_to_connection_str |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bewithgaurav
changed the title
…crosoft/mssql-python into bewithgaurav/remove-dead-code
jahnvi480
approved these changes
Jan 20, 2026
bewithgaurav
changed the title
helpers.py & Fix PR Description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request removes unused helper functions related to connection string manipulation from the
mssql_python.helpersmodule. The primary focus is on cleaning up the codebase by eliminating theadd_driver_to_connection_strandadd_driver_name_to_app_parameterfunctions, as well as their import and usage.Code cleanup and removal of unused functions:
add_driver_to_connection_strfrommssql_python/helpers.pyinconnection.py, as it is no longer used.add_driver_to_connection_strfunction, which previously handled injecting a default ODBC driver into the connection string.add_driver_name_to_app_parameterfunction, which previously ensured theAPPparameter was set in the connection string.