Add ability to select single/multiple line(s) by clicking the line numbers(#583) #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber and or dragging across
Author
|
@microsoft-github-policy-service agree |
Nucs
pushed a commit
to Nucs/ogedit
that referenced
this pull request
Nov 29, 2025
Click on line numbers in the left margin to select entire lines: - Single click: selects the entire line - Shift+click: extends selection to clicked line - Click and drag: select multiple lines Based on PR microsoft#622 by jenia90 (microsoft#622) Also adds additional dialog logging coverage (log_dialog_open/close). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Leonard Hecker <leonard@hecker.io>
So, it turns out that `supportedOS` was being ignored because it was taken to be in the default `asm.v1` namespace. :)
…crosoft#639) edit will now display specific error messages when the console fails to support `ENABLE_VIRTUAL_TERMINAL_INPUT`. The user will be gently reprimanded for not using the modern console host. It is technically possible to run edit on OpenConsole (or another third- party console host!)--even on Windows 8.1--where it will work properly.
`panic_immediate_abort` is being stablized as `panic = immediate-abort` (yay!). See: rust-lang/rust#147286 Closes microsoft#657
This will allow us to use the `Arena` in `build.rs`. This changeset also contains a version bump of all dependencies.
Co-authored-by: MKAbuMattar <mohamamd.khaled@outlook.com>
Fixed: * `sighandler_t` warning in nightly * cppdbg + gdb pretty printing * UTF8 parsing for SGR mouse coords
Alt does not work in macOS.
…ft#738) Closes microsoft#737 Co-authored-by: Leonard Hecker <leonard@hecker.io>
The main change is adding multithreading support in order to make JSON unit tests work properly. The TLS overhead is not _that bad. Other changes: * Switch to `io::Result`, because `AllocError` doesn't transmit error codes (meh!) * Reduce x86 commit chunk size to 32KiB * Improved performance slightly by inlining harder (`alloc_uninit`) and outlining the result unwrap (`alloc_raw_bump`)
This is a bog-standard JSONC parser. Not much to be said. Its performance is quite alright. Depends on microsoft#741
Supports `*` and `**` patterns. That's enough for our upcoming purposes.
* Use `io::Error` for OS error handling (This results in some added bloat, but is more convenient for now.) * Add an `icu` error type * Move `apperr` from the library into the binary This also sneaks in a minor improvement to sorting. The only two places we need to sort, don't need stable sorting. (Unstable sorting is a lot faster and simpler.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #583.
If you click a single line it will select it. If you click and drag over the line numbers it will select multiple lines.
Hope it helps :)