Spelling by jsoref · Pull Request #1048 · microsoft/charticulator

jsoref · 2022-10-02T20:29:01Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@6a6d4eb#commitcomment-85635162

The action reports that the changes in this PR would make it happy: jsoref@21a7cf2

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref

Most corrections automatically suggested by Google Sheets. All fault mine.

jsoref · 2022-10-02T20:29:35Z

src/app/actions/actions.ts

  public digest() {
    return {
-      name: "MapChartElementkAttribute",
+      name: "MapChartElementAttribute",


It's possible this is important...

jsoref · 2022-10-02T20:30:46Z

src/app/application.tsx


 export class ApplicationExtensionContext implements ExtensionContext {
-  constructor(public app: Application) {}
+  constructor(public app: Application) { }


I didn't do this. But I apparently opened this file in VSCode and some reformatting rule apparently insisted (it also rewrote my workflow yaml).

I'm willing to drop these changes, but do note that files should not trip up drive-by-contributors which means someone should really clean up the codebase so this doesn't happen when the next person drives by.

jsoref · 2022-10-02T20:31:00Z

src/app/application.tsx

      worker?: CharticulatorWorkerInterface;
    },
-    localizaiton: LocalizationConfig,
+    localization: LocalizationConfig,


It's possible this is a public api. I hope it isn't...

jsoref · 2022-10-02T20:31:22Z

src/app/components/index.ts

 export * from "./error_boundary";
 export * from "./editable_text_view";
-export * from "./messsage_box";
+export * from "./message_box";


File renamed below

jsoref · 2022-10-02T20:31:58Z

src/app/utils/index.ts

 }

-export function getAligntment(anchor: Element) {
+export function getAlignment(anchor: Element) {


It's possible this is an api

jsoref · 2022-10-02T20:36:41Z

src/core/prototypes/plot_segments/axis.ts

    }
    const g = makeGroup([]);
-    const gridineArcRotate = 90;
+    const gridlineArcRotate = 90;


jsoref · 2022-10-02T20:37:30Z

src/core/prototypes/plot_segments/index.ts

- * Plotsegmets are high level elements of charticulator responsible for layout and arrange other elements (glyph's and marks)
+ * Plotsegments are high level elements of charticulator responsible for layout and arrange other elements (glyph's and marks)
 *
- * ![Plot segmets](media://plotsegmets_scaffolds.png)


I can't find this file

jsoref · 2022-10-02T20:38:01Z

src/core/prototypes/plot_segments/virtualScroll.tsx

 import { AxisDataBindingType } from "../../specification/types";

-export interface VirtualScrollBarPropertes {
+export interface VirtualScrollBarProperties {


jsoref · 2022-10-02T20:38:24Z

src/core/solver/plugins/polar_coordinator.ts


 // eslint-disable-next-line
-export interface PolarCoordinatorPluginOptions {}
+export interface PolarCoordinatorPluginOptions { }


See earlier note about random whitespace changes from formatters

jsoref · 2022-10-02T20:38:59Z

src/index.ts

 *
 * * Solve sparse linear least square problems.
- * * Solve sparse constrained linear least square problems using a lagrange method.
+ * * Solve sparse constrained linear least square problems using a Lagrange method.


Eigen below is capitalized. I don't see any reason not to treat Lagrange with similar respect.

jsoref · 2022-10-11T23:52:45Z

@bongshin: do I need to do something to push this along?

jsoref added 30 commits October 2, 2022 13:55

spelling: align

c88bd24

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: alignment

62ebbdb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: assume

5809aaf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: attribute

97ff00b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: attributes

b2d5c07

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: available

8943aef

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: background

5c8e744

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: bracket

64b9fa7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: can

52bb551

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: charticulator

c50ae23

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: classes

8f8805e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: collapse

2e78c8a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: column

7b73061

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: columns

2caee9c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: components

8a85f1d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: configuration

465aef2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: constraints

3119966

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: contains

93e64d7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: conversion

a63591f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: coordinate

114a67f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: coordinator

8824608

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: count

bacd70a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: curve

890170c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dataset

8faec8f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: decimal

c38eba6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: default

2e36077

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: delimiter

f952a91

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: description

1cbc1bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: design

b4176dc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: different

b267542

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 27 commits October 2, 2022 16:23

spelling: message

f3dfed2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: object

f9b86ed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: objects

0f26eda

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: parsed

13ccf8a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: priority

273a59b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: properties

7d1223a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: providers

bfd3a7b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: ratio

d8ed3e7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: rectangle

2fbc1ef

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: removal

bd7bf51

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: response

74686b2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: returns

21d8d90

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: right

a052081

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: segment

71bfba1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: spiral

7247cf2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: stringify

a25a4bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: structures

350ae23

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: subtitle

45e49bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: template

d2f47a4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: than

e4370de

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: undefined

539fce6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: updates

30fbe86

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: value

b5372d9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: values

6356065

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: variable

1067327

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: visible

5c550bf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: work

c5d03bd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Oct 2, 2022

View reviewed changes

zBritva approved these changes Oct 3, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling#1048

Spelling#1048
jsoref wants to merge 79 commits intomicrosoft:masterfrom
jsoref:spelling

jsoref commented Oct 2, 2022

Uh oh!

jsoref left a comment

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref Oct 2, 2022

Uh oh!

jsoref commented Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jsoref commented Oct 2, 2022

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsoref commented Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants