Fix miscalculated LUT scale factor#53
Draft
natelowry wants to merge 1 commit intomicrosoft:masterfrom
Draft
Conversation
The fake depth frame is set to 1000mm, but the example code was dividing the transformation result by 1,000,000, making the lookup table values off by a factor of 1000.
Author
|
i'm looking for an existing issue right now, if there isn't one i'm happy to create one. again, i may be doing something wrong...is the point cloud viewer expecting values in meters? is there an implicit coordinate system change at the end i'm missing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fake depth frame is set to 1000mm, but the example code was dividing the transformation result by 1,000,000, making the lookup table values off by a factor of 1000.
Maybe I'm missing something here, but when I put (pretty much) this exact method in my test code my point cloud values were all off by 1000x.