Added anomaly detection script and requirements file#140
Open
swastik-21 wants to merge 1 commit intomicrosoft:masterfrom
Open
Added anomaly detection script and requirements file#140swastik-21 wants to merge 1 commit intomicrosoft:masterfrom
swastik-21 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
… requirements.txt
Author
|
@microsoft-github-policy-service agree |
QuantumAlchemist03
left a comment
There was a problem hiding this comment.
Added a few suggestions for improvements. Overall looks good!
There was a problem hiding this comment.
The anomaly detection function is clear and well-documented. A few suggestions:
- Consider adding a check for std == 0 to avoid division by zero errors.
- In the example usage, it might help to explain why z_thresh=2.0 is chosen (e.g., more sensitive to outliers).
- Optionally, you could mention that this method assumes a roughly normal distribution for data.
There was a problem hiding this comment.
This requirements.txt is clear and version-pinned, which is great for reproducibility. A few suggestions:
- Double-check if numpy==2.3.2 and pandas==2.3.2 are compatible; sometimes older versions of one library may conflict with the other.
- Consider whether all dependencies (like
sixortzdata) are actually used in the project — removing unused packages can simplify the environment. - Optionally, you could mention Python version compatibility, e.g., if this works for Python 3.11 or higher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I’ve added a simple anomaly detection script under ai_modules/anomaly_detection.py. Right now it uses a z-score approach to flag unusual values in water usage data. The threshold can be adjusted so it works with different datasets.
I also created a requirements.txt so dependencies can be installed more easily.
Tested locally with sample data, and it correctly flagged extreme outliers. This is an initial version, so open to feedback or suggestions on improvements.
Thanks