Change import paths to fix 'no buildable Go source files error' re: logxi#70
Open
Change import paths to fix 'no buildable Go source files error' re: logxi#70
Conversation
added 2 commits
May 11, 2017 13:27
Author
|
I've updated tests and running them manually produces no build errors. Continuous integration would be a helpful addition here, maybe TravisCI? |
Author
|
@mgutz ping |
|
I am having the same issue while running automated build on CircleCI. @mgutz can you merge this PR please? |
Janulka
added a commit
to Janulka/dat
that referenced
this pull request
Jun 1, 2017
|
@mgutz any update on this ? I am having the same issue |
|
this should most definitely be fixed |
|
Is there any progress? |
|
Project seems to be unusable without this.. and the issue is outstanding for 9 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
Currently, the project is unusable with current
glide.lock. The root cause is that the currentglide.lockrepresents a dependency graph that is not compatible withv1changes introduced here: f2918ee#diff-33921aca24f9053a9a0b9e289014da32R3l have:
logxi imports in dat.v1 to include thev1packagejodependency back to the version with av1package, as dat imports still rely on that package.