Open
Conversation
|
can someone approve this pr? this is the feature i love. |
janisz
approved these changes
Apr 24, 2019
|
when can this feature be merged? |
|
Yes, please add jq! :-) |
larstobi
reviewed
Apr 25, 2019
| mailcap \ | ||
| && \ | ||
| pip install --upgrade awscli==1.14.5 s3cmd==2.0.1 python-magic && \ | ||
| pip install --upgrade awscli==1.16.11 s3cmd==2.0.2 python-magic && \ |
There was a problem hiding this comment.
@brentryan I suppose it might be easier to get this merged if you only add the new jq line, and not introduce new versions of awscli and s3cmd in the same commit.
|
I ended up switching to https://hub.docker.com/r/mikesir87/aws-cli -- has jq and has tags for aws-cli versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some jq love!