Cleaning up the MoveUp and MoveDown functions#45
Merged
matze merged 6 commits intomatze:masterfrom Jul 5, 2020
Merged
Conversation
The calls to min() and max() ensure that these conditions are never true.
Reduce code duplication by replacing MoveLineUp and MoveLineDown by a single function, MoveLineVertically.
Reduce code duplication by replacing MoveBlockUp and MoveBlockDown by a single function, MoveBlockVertically.
Reduce code duplication by putting the computation of half page size in a separate function.
People might expect that any truthy value should work to enable auto indent, and not just 1.
Owner
|
Looks good, less code is always better 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the code for moving things up and down, getting rid of some code duplication. Some of these ideas are from PR #27.