fix: Race condition in sampling force-one logic#23707
Merged
mergify[bot] merged 3 commits intomatrixorigin:mainfrom Feb 8, 2026
Merged
fix: Race condition in sampling force-one logic#23707mergify[bot] merged 3 commits intomatrixorigin:mainfrom
mergify[bot] merged 3 commits intomatrixorigin:mainfrom
Conversation
XuPeng-SH
requested review from
aunjgr,
gouhongshen and
ouyuanning
as code owners
gouhongshen
approved these changes
Feb 8, 2026
aunjgr
approved these changes
Feb 8, 2026
Contributor
Merge Queue Status✅ The pull request has been merged at 425e77d This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23706
What this PR does / why we need it:
Increment
sampledObjectCountimmediately while holding the lock to prevent other goroutines from also seeingsampledObjectCount == 0and being forced into Phase 2.