IGNOREME: distance functions with golang simd (v1.26)#23503
Draft
cpegeric wants to merge 59 commits intomatrixorigin:mainfrom
Draft
IGNOREME: distance functions with golang simd (v1.26)#23503cpegeric wants to merge 59 commits intomatrixorigin:mainfrom
cpegeric wants to merge 59 commits intomatrixorigin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #23502
What this PR does / why we need it:
distance functions implemented by simd instruction with golang v1.26.
PR Type
Enhancement
Description
Implement SIMD-optimized distance functions for x86_64 architecture
Refactor distance function resolution into separate module
resolve.goAdd float32 test cases for L2 distance squared calculation
Update Makefile to support GOEXPERIMENT=simd and GOAMD64 configuration
Diagram Walkthrough
File Walkthrough
distance_func.go
Mark as non-amd64 fallback, remove resolution functionspkg/vectorindex/metric/distance_func.go
//go:build !amd64to mark as non-amd64 fallbackresolve.go)resolve.go
Extract distance function resolution to separate modulepkg/vectorindex/metric/resolve.go
ResolveKmeansDistanceFn,ResolveKmeansDistanceFnForDense,ResolveKmeansDistanceFnForSparseResolveDistanceFnfor general distance function selectiondistance_func_amd64.go
SIMD-optimized distance functions for x86_64pkg/vectorindex/metric/distance_func_amd64.go
distance_func_test.go
Add float32 L2 distance squared testspkg/vectorindex/metric/distance_func_test.go
Test_L2DistanceSqFp32test function with 6 test casessizes
Makefile
Add GOEXPERIMENT=simd and GOAMD64 build configurationMakefile
GOvariable support for custom Go binary pathGOEXPERIMENT_OPTto enable SIMD experiment for x86_64GOAMD64flag support for specifying AMD64 microarchitecturelevel
TAGStoGOTAGSfor proper tag formatting$(GO)and$(GOEXPERIMENT_OPT)variables