Update internal get_BZ() usage to resolve UserWarnings
#117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-reents
approved these changes
Jan 29, 2026
Collaborator
t-reents
left a comment
t-reents
left a comment
There was a problem hiding this comment.
Thanks @kurtmckee!
I agree, it obviously makes a lot of sense to update our own tests to the new API. I just remember that I initially kept in on purpose, to see that the changes didn't break anything, after taking over the maintenance. However, I didn't come back to this part when doing the actual release.
I also agree with the suggestion regarding the warnings. We'll take care of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
There are a number of warnings coming from spglib regarding a behavioral change in its exception handling.
These errors are not addressed in this PR, but the warnings indicate a significant behavioral change that needs to be reviewed.
In general, I recommend addressing the spglib warnings and then enabling this configuration in
pyproject.toml:This will escalate warnings to errors to flag behavioral changes in dependencies, and sometimes in Python itself!