Jdp debugger client tests

[grgustaf]

No description provided.

[grgustaf]

@martijnthe, when I just said jest.mock('ws') that worked up until this last test I'm trying to write, but I'm wanting to emit events on the websocket to get the on('open') handler called and such. Here is my not working attempt so far...

[martijnthe]

Ah sorry I missed this PR and it's conflicting with the changes I made w.r.t. switching to the nicer CLI arg parser. Mind rebasing / updating this?

[grgustaf]

Yeah, I'll try to get back to this at some point.

[grgustaf]

I tried and failed to mock stuff like on() and emit() in the WebSocket module to test additional the 'open' and 'error' cases etc, but just couldn't make it work. Part of the difficulty I think is that the WebSocket module is a constructor. Maybe later I'll have learned enough about Jest to make it work, but moving on to other things.

[grgustaf]

Realized lint was failing - fixed two issues but the third one requires me to return the promise - if I do I realize it's not getting resolved, and I'm back to that problem where I can't figure out how to override functions in the WebSocket mock to provide this functionality. @martijnthe, any insight?

[martijnthe]

@grgustaf this fixes it:

diff --git a/jerry-debugger/jerry-client-ts/src/lib/__tests__/debugger-client.test.ts b/jerry-debugger/jerry-client-ts/src/lib/__tests__/debugger-client.test.ts
index 278818dd..82cebeea 100644
--- a/jerry-debugger/jerry-client-ts/src/lib/__tests__/debugger-client.test.ts
+++ b/jerry-debugger/jerry-client-ts/src/lib/__tests__/debugger-client.test.ts
@@ -42,7 +42,7 @@ describe('JerryDebugger.connect', () => {
   it('creates a websocket', () => {
     const delegate = {} as any;
     const jd = new JerryDebuggerClient({ delegate });
-    jd.connect();
+    jd.connect().catch((e) => { throw e; });
     expect(WebSocket).toHaveBeenCalledTimes(1);
   });
 });

You could also use await jd.connect(); (and make the test function async) but then you'll have to change the mock to also resolve, otherwise the test will time out.
If not using await you need to at least .catch() the result of promise, because otherwise if there was an error being thrown inside the Promise executor function, it could go by unnoticed.

[martijnthe]

Maybe later I'll have learned enough about Jest to make it work, but moving on to other things.

OK, sounds good.