Throw error explicitly using the callback instead of failing due to "Cannot read property 'filename' of undefined"

[omrilit]

No description provided.

[jagadeesh93]

@omrilit Hii , I am also facing the same issue on the version 3.0.1, Is there any fix for this , Thanks in advance

[omrilit]

@omrilit Hii , I am also facing the same issue on the version 3.0.1, Is there any fix for this , Thanks in advance

@jagadeesh93 not that I am aware of. I've just forked the repo and added this PR's content. You can see it at https://github.com/salto-io/node-html-pdf

[barakplasma]

This one line change looks good to me. We've also been experiencing this issue on a regular basis since upgrading to v3.0.1

[barakplasma]

I have a suspicion that this bug might be caused by phantomjs failing but html-pdf not catching it and counting on there being a file when there isn't one. PR 644 might solve this issue

[barakplasma]

For a patch in the meanwhile, see #644 (comment) . I'm going to rollout the patch in prod, ping me later if you're interested in whether it solved the issue for me.

[omrilit]

@barakplasma it would be great if you could write here if it worked for you.

[barakplasma]

I haven't deployed to prod yet, so no news.
However, I did write a case to recreate this particular bug in my branch which shows that the fix in #644 does prevent the bug we are experiencing in this issue.

[barakplasma]

@omrilit your mileage may vary, but I deployed the fix in #644 to prod, and we haven't had that error since