use phantomJS paperSize margin property in place of border#412
Open
TomCoded wants to merge 1 commit intomarcbachmann:masterfrom
Open
use phantomJS paperSize margin property in place of border#412TomCoded wants to merge 1 commit intomarcbachmann:masterfrom
TomCoded wants to merge 1 commit intomarcbachmann:masterfrom
Conversation
margin replaced border six years ago in phantomJS, although backward compatibility still allows the border property to function correctly. This change updates html-pdf to use the margin property and to continue recognizing the border property for backward compatitiblity. fixes: marcbachmann#403 refs: ariya/phantomjs@a638a07
|
@marcbachmann could this merged please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
margin replaced border six years ago in phantomJS, although
backward compatibility still allows the border property
to function correctly.
This change updates html-pdf to use the margin property and
to continue recognizing the border property for backward
compatitiblity.
fixes: #403
refs: ariya/phantomjs@a638a07