serviceability: require Activated status for UnlinkDeviceInterface#2871
Open
martinsander00 wants to merge 1 commit intomainfrom
Open
serviceability: require Activated status for UnlinkDeviceInterface#2871martinsander00 wants to merge 1 commit intomainfrom
martinsander00 wants to merge 1 commit intomainfrom
Conversation
martinsander00
force-pushed
the
ms/2230
branch
from
f2e4b5e to
12292a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2230
Summary
UnlinkDeviceInterfacepreviously only rejected interfaces inDeletingstatus, allowing unlinking from any other status includingPendingiface.status == Activatedbefore unlinking, returningInvalidStatusotherwiseTesting Verification
test_unlink_device_interface_requires_activatedthat verifies unlinking aPendinginterface fails withInvalidStatus(0x7) and succeeds after activation