sdk: migrate all Go consumers to new serviceability SDK and remove old one #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snormore
force-pushed
the
snor/serviceability-telemetry-sdks
branch
2 times, most recently
from
77b5f96 to
0d56ff2
Compare
snormore
force-pushed
the
snor/migrate-to-new-serviceability-sdk
branch
from
ffccd30 to
45c36c5
Compare
snormore
force-pushed
the
snor/serviceability-telemetry-sdks
branch
2 times, most recently
from
8ab0cd6 to
3bf2ac2
Compare
snormore
force-pushed
the
snor/migrate-to-new-serviceability-sdk
branch
8 times, most recently
from
51df8e3 to
986f00d
Compare
Move ToLineProtocol into monitor's internal serviceability package since the new SDK is read-only and doesn't include InfluxDB helpers.
DeviceStatus, LinkStatus, and LinkDesiredStatus enum values didn't account for the deprecated Suspended status (value 2) being skipped in the Rust smart contract. This caused IsDrained() to return false for drained devices, breaking the IBRL drain test.
snormore
force-pushed
the
snor/migrate-to-new-serviceability-sdk
branch
from
986f00d to
13f885d
Compare
Replace require.Eventually + t.Fatalf pattern in waitForDeviceLatencySamples with a manual polling loop. t.Fatalf inside Eventually's condition function runs in a goroutine where runtime.Goexit() only exits that goroutine, causing Eventually to retry until timeout with confusing "context canceled" errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
smartcontract/sdk/go/serviceability) to the new read-only SDK (sdk/serviceability/go)ToLineProtocolInfluxDB helper intocontrolplane/monitor/internal/serviceabilitysince the new SDK is read-onlyProgramDataProviderinterface andIsDrained()/IsHardDrained()methods to the new SDK to support consumers that need themProgramConfigas pointer,Config→GlobalConfig, field renames (TunnelTunnelBlock→DeviceTunnelBlock,Local_asn→LocalASN), removed statuses (*Suspended→*Deleting)Testing Verification