-
Notifications
You must be signed in to change notification settings - Fork 7
Advanced search - OpenSearch configuration #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds OpenSearch-based advanced search docs and environment variables, and reorders navigation to place Changes
Sequence Diagram(s)sequenceDiagram
participant User as "User"
participant API as "Plane API Pod"
participant Redis as "Redis"
participant Cel as "Celery Workers"
participant OS as "OpenSearch"
User->>API: Trigger indexing or search request
API->>Redis: Enqueue indexing task
Redis--)Cel: Task queued (pub/sub)
Cel->>API: Fetch task details
Cel->>OS: Index documents (bulk/index API)
OS-->>Cel: Acknowledge
Cel-->>API: Task completion status
API-->>User: Confirm indexing / return search results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@self-hosting/govern/advanced-search.mdx`:
- Around line 42-48: The OPENSEARCH_INDEX_PREFIX example uses a trailing
underscore ("plane_") which combined with templates that append "_issues" will
produce a double underscore; update all examples (the OPENSEARCH_INDEX_PREFIX
values shown and any Helm/chart defaults) to use a prefix without a trailing
underscore (e.g., "plane") or adjust the index-template to concatenate safely
(avoid "{prefix}_issues" when prefix already ends with "_"); specifically change
occurrences of OPENSEARCH_INDEX_PREFIX that show "plane_" to "plane" (also apply
the same fix at the other mentioned locations).
- Around line 121-131: Replace the misspelled word "commmands" with "commands"
in the two occurrences inside the advanced-search content (the lines that read
"Run these commmands in the API pod." before the bash block that starts with "#
Get the API pod name" and the later "Run these commmands in the API pod." under
"4. **Index your existing data**"); update both instances so the phrase reads
"Run these commands in the API pod." to correct the typo.
- Around line 155-165: Replace the insecure example that sets verify_certs=False
with guidance and a snippet that uses verify_certs=True and a CA bundle
(referencing OpenSearch constructor, verify_certs, ca_certs and
settings.OPENSEARCH_DSL['default'] values); keep a short note that
verify_certs=False is only a temporary, non-production workaround for
self-signed testing and should not be recommended, and show providing
ca_certs="/path/to/ca-bundle.pem" or relying on the system/certifi CA store as
the secure default.
In `@self-hosting/govern/environment-variables.mdx`:
- Around line 142-148: The OPENSEARCH_INDEX_PREFIX table row has the Description
and Default Value columns swapped; update the row for the
`OPENSEARCH_INDEX_PREFIX` entry so the Description column reads "Prefix for all
index names (useful for multi-tenant setups)" and the Default Value column reads
"(empty)"—ensure the table cell order matches the other rows and the header
(Variable | Description | Default Value).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@self-hosting/govern/advanced-search.mdx`:
- Around line 277-279: Replace the unhyphenated phrase "full text search" with
"full‑text search" in the text block that currently reads "Work items benefit
from full text search."; ensure any other occurrences of the adjective phrase
"full text" in the document are similarly hyphenated to "full‑text" so the
compound modifier is correct.
♻️ Duplicate comments (1)
self-hosting/govern/advanced-search.mdx (1)
155-164: Avoidverify_certs=Falsein the default snippet.Line 162 disables TLS verification; that’s unsafe as a default. Prefer
verify_certs=Truewith a CA bundle (or system/Certifi CA store) and only mentionFalseas a temporary dev/test workaround.🔒️ Suggested secure snippet
client = OpenSearch( hosts=[settings.OPENSEARCH_DSL['default']['hosts']], http_auth=settings.OPENSEARCH_DSL['default']['http_auth'], use_ssl=True, - verify_certs=False + verify_certs=True, + ca_certs="/path/to/ca-bundle.pem" # or omit to use system/certifi CA store )OpenSearch Python client verify_certs ca_certs recommended production settings
🧹 Nitpick comments (1)
self-hosting/govern/environment-variables.mdx (1)
140-148: Match table formatting with the rest of the doc.Line 142–148 uses backticks for variable names and a plain “(empty)” default, while earlier sections use bold variable names and italicized empty defaults. Consider aligning for consistency.
♻️ Suggested tweak
-| `OPENSEARCH_ENABLED` | Enable OpenSearch integration | `1` | -| `OPENSEARCH_URL` | OpenSearch endpoint URL | `https://opensearch.example.com:9200/` | -| `OPENSEARCH_USERNAME` | Authentication username | `admin` | -| `OPENSEARCH_PASSWORD` | Authentication password | `your-secure-password` | -| `OPENSEARCH_INDEX_PREFIX` | Prefix for all index names (useful for multi-tenant setups) | (empty) | +| **OPENSEARCH_ENABLED** | Enable OpenSearch integration | `1` | +| **OPENSEARCH_URL** | OpenSearch endpoint URL | `https://opensearch.example.com:9200/` | +| **OPENSEARCH_USERNAME** | Authentication username | `admin` | +| **OPENSEARCH_PASSWORD** | Authentication password | `your-secure-password` | +| **OPENSEARCH_INDEX_PREFIX** | Prefix for all index names (useful for multi-tenant setups) | *(empty)* |
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.