This repository was archived by the owner on Jun 2, 2019. It is now read-only.
Fixed possible cyclic dep when used with other modules#46
Open
pulquero wants to merge 1 commit intomaestrodev:masterfrom
Open
Fixed possible cyclic dep when used with other modules#46pulquero wants to merge 1 commit intomaestrodev:masterfrom
pulquero wants to merge 1 commit intomaestrodev:masterfrom
Conversation
"cwd => '/opt'" implies that /opt should exist, so there should be an explicit file {'opt':}. This fixed some cyclic dep hell for me.
Member
|
I don't think it is needed, from https://docs.puppetlabs.com/references/latest/type.html#exec
but it doesn't say that the dir needs to be defined, and the tests are passing without it I'm reluctant to add new dir creation because even inside |
|
Possibly simpler solution: Can we just use /tmp as the cwd, and mkdir -p if we really need it to be /opt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"cwd => '/opt'" implies that /opt should exist, so there should be an explicit file {'opt':}. This fixed some cyclic dep hell for me.