Skip to content

Alarm consistency #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imbercal wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Alarm consistency #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions LoopFollow/Alarm/AlarmEditing/Editors/COBAlarmEditor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ struct COBAlarmEditor: View {
var body: some View {
Group {
InfoBanner(
text: "Alerts when Carbs-on-Board exceeds the amount you set below.",
text: "Alerts when Carbs-on-Board reaches or exceeds the amount you set below.",
alarmType: alarm.type
)

AlarmGeneralSection(alarm: $alarm)

AlarmStepperSection(
header: "Carbs on Board Limit",
footer: "Alert when carbs-on-board is above this number.",
title: "Above",
footer: "Alert when carbs-on-board is at or above this number.",
title: "At or Above",
range: 1 ... 200,
step: 1,
unitLabel: "g",
Expand Down
8 changes: 4 additions & 4 deletions LoopFollow/Alarm/AlarmEditing/Editors/MissedBolusAlarmEditor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ struct MissedBolusAlarmEditor: View {

AlarmStepperSection(
header: "Ignore small boluses",
footer: "Boluses below this size are ignored.",
title: "Ignore below",
footer: "Boluses at or below this size are ignored.",
title: "Ignore at or below",
range: 0.05 ... 2,
step: 0.05,
unitLabel: "Units",
Expand All @@ -51,8 +51,8 @@ struct MissedBolusAlarmEditor: View {

AlarmStepperSection(
header: "Ignore small carbs",
footer: "Carb entries below this amount will not trigger the alarm.",
title: "Below",
footer: "Carb entries at or below this amount will not trigger the alarm.",
title: "At or Below",
range: 0 ... 15,
step: 1,
unitLabel: "Grams",
Expand Down
2 changes: 1 addition & 1 deletion LoopFollow/Alarm/AlarmEditing/Editors/PhoneBatteryAlarmEditor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ struct PhoneBatteryAlarmEditor: View {

AlarmStepperSection(
header: "Battery Level",
footer: "This alerts you when the battery drops below this level.",
footer: "This alerts you when the battery drops to or below this level.",
title: "Battery Below",
range: 0 ... 100,
step: 5,
Expand Down
2 changes: 1 addition & 1 deletion LoopFollow/Alarm/AlarmEditing/Editors/PumpBatteryAlarmEditor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ struct PumpBatteryAlarmEditor: View {

AlarmStepperSection(
header: "Pump Battery Level",
footer: "This alerts you when the pump battery drops below this level.",
footer: "This alerts you when the pump battery drops to or below this level.",
title: "Battery Below",
range: 0 ... 100,
step: 5,
Expand Down
4 changes: 2 additions & 2 deletions LoopFollow/Alarm/AlarmEditing/Editors/RecBolusAlarmEditor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ struct RecBolusAlarmEditor: View {

AlarmStepperSection(
header: "Threshold",
footer: "Alert when recommended bolus is above this value.",
title: "More than",
footer: "Alert when recommended bolus is at or above this value.",
title: "At or Above",
range: 0.1 ... 50,
step: 0.1,
unitLabel: "Units",
Expand Down